Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 928723003: Revert of [x64] Improve instruction selection for TruncateInt64ToInt32. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [x64] Improve instruction selection for TruncateInt64ToInt32. (patchset #1 id:1 of https://codereview.chromium.org/936323004/) Reason for revert: Breaks SQLite Original issue's description: > [x64] Improve instruction selection for TruncateInt64ToInt32. > > R=svenpanne@chromium.org > > Committed: https://crrev.com/64a2717529e2197f3a789adabf86ca36f5eb764c > Cr-Commit-Position: refs/heads/master@{#26739} TBR=svenpanne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/61ac461330d7f9cf36a71a6f8cff6c47857ed02a Cr-Commit-Position: refs/heads/master@{#26791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -59 lines) Patch
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +5 lines, -17 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 2 chunks +39 lines, -42 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Benedikt Meurer
Created Revert of [x64] Improve instruction selection for TruncateInt64ToInt32.
5 years, 10 months ago (2015-02-23 07:08:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928723003/1
5 years, 10 months ago (2015-02-23 07:09:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 07:09:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 07:09:23 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/61ac461330d7f9cf36a71a6f8cff6c47857ed02a Cr-Commit-Position: refs/heads/master@{#26791}
5 years, 10 months ago (2015-02-23 07:09:37 UTC) #5
Michael Achenbach
Is this revert required to be merged back to 4.2?
5 years, 10 months ago (2015-02-23 09:26:31 UTC) #6
Benedikt Meurer
5 years, 10 months ago (2015-02-23 09:26:56 UTC) #7
Message was sent while issue was closed.
Probably, yes.

Powered by Google App Engine
This is Rietveld 408576698