Allow --force-uninstall for SxS Chrome and disallow --self-destruct.

Allow --force-uninstall for SxS Chrome and disallow --self-destruct.

--self-destruct does not make sense for SxS since SxS cannot be
installed at system-level. --force-uninstall is useful for debugging and
testing, so there is no reason not to support it for SxS.

BUG=456602
R=gab@chromium.org

Committed: https://crrev.com/035e1a96b311e92529f4f7d4da9dc869db21e73e
Cr-Commit-Position: refs/heads/master@{#316645}

[gab, 2015-02-17 19:15:32]

lgtm but I somewhat disagree with the CL description:

> Prior to r175249, --force-uninstall was the way that system-level Chrome
> made user-level Chrome self-destruct. 

It wasn't "the way that system-level Chrome made user-level Chrome
self-destruct", it just happened to be one of the flags it used, but that didn't
make the uninstall self-destruct aware (it only made it not use UI).

IMO it probably never made sense not to support --force-uninstall for Chrome
SxS.

Perhaps simply mention that --self-destruct shouldn't be (and never should have
been) supported by Chrome SxS, while supporting --force-uninstall is useful for
debugging (and that there really is no reason not to support it today).

[grt (UTC plus 2), 2015-02-17 19:44:58]

On 2015/02/17 19:15:32, gab wrote:
> lgtm but I somewhat disagree with the CL description:
> 
> > Prior to r175249, --force-uninstall was the way that system-level Chrome
> > made user-level Chrome self-destruct. 
> 
> It wasn't "the way that system-level Chrome made user-level Chrome
> self-destruct", it just happened to be one of the flags it used, but that
didn't
> make the uninstall self-destruct aware (it only made it not use UI).
> 
> IMO it probably never made sense not to support --force-uninstall for Chrome
> SxS.
> 
> Perhaps simply mention that --self-destruct shouldn't be (and never should
have
> been) supported by Chrome SxS, while supporting --force-uninstall is useful
for
> debugging (and that there really is no reason not to support it today).

Thanks. Description updated.

[grt (UTC plus 2), 2015-02-17 19:45:01]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2015-02-17 19:45:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/928713003/1

[commit-bot: I haz the power, 2015-02-17 20:32:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-17 20:33:13]

Patchset 1 (id:??) landed as
https://crrev.com/035e1a96b311e92529f4f7d4da9dc869db21e73e
Cr-Commit-Position: refs/heads/master@{#316645}