Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 928673002: Exit HTML Fullscreen when browser fullscreen is active. (Closed)

Created:
5 years, 10 months ago by scheib
Modified:
5 years, 10 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri (slow - plz ping), nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exit HTML Fullscreen when browser fullscreen is active. Ensure web contents exit fullscreen state by sending a resize message, which includes the fullscreen state. This is required for the situation of the browser moving the view into a fullscreen state "browser fullscreen" and then the contents entering "tab fullscreen". Exiting the contents "tab fullscreen" then won't have the side effect of the view resizing, hence the explicit call here is required. Fixes a regression caused in the refactoring Fullscreen: make fullscreen requests come from RenderFrame https://codereview.chromium.org/789533002 https://crrev.com/7a78d6fd7dc3241a91a614a09f9c59a0e4454135 where the previous implementation's call to WasResized in RenderViewHostImpl::OnToggleFullscreen was not brought forward to WebContentsImpl::ExitFullscreenMode(). BUG=458013 TEST=Open http://scheib.github.io/HTMLMisc/PointerLockAndFullscreen.html, enter Browser Fullscreen with F11 key, press Toggle Fullscreen button, press ESC key, expect content to exit fullscreen. Committed: https://crrev.com/3dcb6c931a974f4e825f5383e98ed5b958819b56 Cr-Commit-Position: refs/heads/master@{#317562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
scheib
Regression fix for M42
5 years, 10 months ago (2015-02-14 00:41:12 UTC) #2
jam
On 2015/02/14 00:41:12, scheib wrote: > Regression fix for M42 really a regression fix should ...
5 years, 10 months ago (2015-02-17 16:50:00 UTC) #3
scheib
jochen, PTAL as initial reviewer of regression. Re jam, tests: Fullscreen features tests are performed ...
5 years, 10 months ago (2015-02-17 17:30:31 UTC) #5
jochen (gone - plz use gerrit)
code lgtm only having manual tests is very sad :(
5 years, 10 months ago (2015-02-23 09:50:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928673002/1
5 years, 10 months ago (2015-02-23 10:23:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 10:56:06 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 10:56:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dcb6c931a974f4e825f5383e98ed5b958819b56
Cr-Commit-Position: refs/heads/master@{#317562}

Powered by Google App Engine
This is Rietveld 408576698