chrome/browser/media/android/remote/DEPS - Issue 928643003: Upstream Chrome for Android Cast.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/media/android/remote/DEPS

Issue 928643003: Upstream Chrome for Android Cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing resource, allowing casting from Chrome Shell Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 specific_include_rules = {

	2 # Fix layering violation crbug.com/396828
	scherkus (not reviewing) 2015/03/12 19:15:04 this bug was filed in july 2014 -- do we have a ti this bug was filed in july 2014 -- do we have a timeline on fixing this? aberent 2015/03/12 20:02:08 I intend to fix this once I have got rid of the do Show quoted text On 2015/03/12 19:15:04, scherkus wrote: > this bug was filed in july 2014 -- do we have a timeline on fixing this? I intend to fix this once I have got rid of the downstream version of the code (soon after this CL lands). The obvious fixes involve either making browser_media_player_manager.h public or making minor changes to other existing interfaces, which would need simultaneous changes to the upstream and downstream repositories. Once the code is all upstream this sort of change will be much easier.
	3 "remote_media_player_manager\.": [

	4 "+content/browser/media/android/browser_media_player_manager.h",

	5 ],

	6

	7 # Fix layering violation crbug.com/396828

	8 "remote_media_player_manager\.cc": [

	9 "+content/common/media/media_player_messages_android.h",

	10 ],

	11

	12 # Fix layering violation crbug.com/396828

	13 "remote_media_player_bridge\.cc": [

	14 "+content/browser/android/content_view_core_impl.h"

	15 ],

	16 }

OLD	NEW