chrome/app/android/DEPS - Issue 928643003: Upstream Chrome for Android Cast.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/app/android/DEPS

Issue 928643003: Upstream Chrome for Android Cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing resource, allowing casting from Chrome Shell Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 specific_include_rules = {

	2 # Fix layering violation crbug.com/396828
	Yaron 2015/03/12 19:02:10 Yeesh. I'd rather not block this massive upstreami Yeesh. I'd rather not block this massive upstreaming (kudos!) based on this but this isn't ideal. Can you prioritize fixing this as a follow-up? aberent 2015/03/12 20:02:08 Yes, I intend to. The reason I didn't do so first Show quoted text On 2015/03/12 19:02:10, Yaron wrote: > Yeesh. I'd rather not block this massive upstreaming (kudos!) based on this but > this isn't ideal. Can you prioritize fixing this as a follow-up? Yes, I intend to. The reason I didn't do so first is that, until I get rid of the downstream version of the code, the obvious fixes require two sided patches. I also need to discuss with Min what the best fix is (e.g. should browser_media_player_manager.h be public?).
	3 "chrome_main_delegate_android.cc": [

	4 "+content/browser/media/android/browser_media_player_manager.h",

	5 ],

	6 }

OLD	NEW