chrome/android/java/res/drawable-v21/notification_icon_bg.xml - Issue 928643003: Upstream Chrome for Android Cast.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/drawable-v21/notification_icon_bg.xml

Issue 928643003: Upstream Chrome for Android Cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable-mdpi/ic_vidcontrol_stop.png ('k') | chrome/android/java/res/drawable-xhdpi-v21/ic_vidcontrol_pause.png » ('j') | chrome/android/java/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteController.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!--

	3 Copyright 2014 The Chromium Authors. All rights reserved.

	4

	5 Use of this source code is governed by a BSD-style license that can be

	6 found in the LICENSE file.

	7 -->

	8

	9 <shape xmlns:android="http://schemas.android.com/apk/res/android"

	10 android:shape="oval" >

	11 <solid android:color="@color/light_active_color" />
	whywhat 2015/02/25 16:31:31 you seem to have changed this from active_control_ you seem to have changed this from active_control_color to light_active_color? is this intentional? aberent 2015/03/10 18:46:46 Yes, I didn't want to move active_control_color in Show quoted text On 2015/02/25 16:31:31, whywhat wrote: > you seem to have changed this from active_control_color to light_active_color? > is this intentional? Yes, I didn't want to move active_control_color into Chromium - They are the same color - Clank uses a mixture of both, and I can find no pattern as to which is used where. - In other uses Chromium uses light_active_color where Clank might use active_control_color (or might use light_active_color) If you understand the intended difference in use, I would consider changing this. whywhat 2015/03/11 18:33:48 Might be Aurimas knows? +aurimas@chromium.org Show quoted text On 2015/03/10 18:46:46, aberent wrote: > On 2015/02/25 16:31:31, whywhat wrote: > > you seem to have changed this from active_control_color to light_active_color? > > is this intentional? > > Yes, I didn't want to move active_control_color into Chromium > - They are the same color > - Clank uses a mixture of both, and I can find no pattern as to which is used > where. > - In other uses Chromium uses light_active_color where Clank might use > active_control_color (or might use light_active_color) > > If you understand the intended difference in use, I would consider changing > this. > Might be Aurimas knows? +aurimas@chromium.org
	12 <size

	13 android:width="40dp"

	14 android:height="40dp"/>

	15 </shape>

OLD	NEW