Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Issue 928633002: Add some tracing for Profiles and Extensions. (Closed)

Created:
5 years, 10 months ago by rkaplow
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some tracing for Profiles and Extensions. This is from investigation on PreMainMessageLoopRunImpl BUG=454789 Committed: https://crrev.com/e65c2ff204265d61af3734c6be6e7eb3fa8c3e66 Cr-Commit-Position: refs/heads/master@{#316391}

Patch Set 1 #

Patch Set 2 : additionally mark some of the traces as startup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M chrome/browser/extensions/component_loader.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 1 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 10 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
rkaplow
5 years, 10 months ago (2015-02-13 22:51:20 UTC) #2
Lei Zhang
lgtm I guess whoever is doing the trace will want both the "browser" and "startup" ...
5 years, 10 months ago (2015-02-13 23:22:48 UTC) #3
rkaplow
On 2015/02/13 23:22:48, Lei Zhang wrote: > lgtm > > I guess whoever is doing ...
5 years, 10 months ago (2015-02-13 23:32:34 UTC) #5
Lei Zhang
On 2015/02/13 23:32:34, rkaplow wrote: > On 2015/02/13 23:22:48, Lei Zhang wrote: > > lgtm ...
5 years, 10 months ago (2015-02-13 23:33:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928633002/20001
5 years, 10 months ago (2015-02-13 23:35:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/25185)
5 years, 10 months ago (2015-02-14 00:28:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928633002/20001
5 years, 10 months ago (2015-02-14 15:59:11 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-14 16:30:02 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 16:31:01 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e65c2ff204265d61af3734c6be6e7eb3fa8c3e66
Cr-Commit-Position: refs/heads/master@{#316391}

Powered by Google App Engine
This is Rietveld 408576698