Issue 928623002: <webview> + <extensionview>: Generalize setValueIgnoreMutation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 928623002: <webview> + <extensionview>: Generalize setValueIgnoreMutation (Closed)

Created:
5 years, 10 months ago by Fady Samuel

Modified:
5 years, 10 months ago

Reviewers:
apacible

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

<webview> + <extensionview>: Generalize setValueIgnoreMutation setValueIgnoreMutation should call setValue so that derived attribute objects only need to modify setValue to get the desired behavior. BUG=none TBR=lazyboy@chromium.org Committed: https://crrev.com/cf84e6eecadb3aebf20a0e561182ca4e42054c6a Cr-Commit-Position: refs/heads/master@{#316318}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	extensions/renderer/resources/guest_view/extension_view_attributes.js	View		2 chunks	+2 lines, -4 lines	0 comments	Download
	M	extensions/renderer/resources/guest_view/web_view_attributes.js	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928623002/1

5 years, 10 months ago (2015-02-13 22:11:50 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-13 23:15:34 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cf84e6eecadb3aebf20a0e561182ca4e42054c6a
Cr-Commit-Position: refs/heads/master@{#316318}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages