Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 928613004: aw: Disable webrtc hardware video decode (Closed)

Created:
5 years, 10 months ago by boliu
Modified:
5 years, 10 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Disable webrtc hardware video decode This never worked in webview and usually fails at run time during context creation. Just disable it for now. BUG= Committed: https://crrev.com/c2cf2db603debf3125438284be17b3c160816fdf Cr-Commit-Position: refs/heads/master@{#316618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
boliu
Michael, do you know any webrtc guru that's appropriate to review this?
5 years, 10 months ago (2015-02-14 01:16:44 UTC) #2
michaelbai
Justin, would you like help to find someone who is working on Android to review ...
5 years, 10 months ago (2015-02-14 01:27:20 UTC) #4
juberti2
On 2015/02/14 01:27:20, michaelbai wrote: > Justin, would you like help to find someone who ...
5 years, 10 months ago (2015-02-17 18:15:06 UTC) #6
AlexGlaznev
On 2015/02/17 18:15:06, juberti2 wrote: > On 2015/02/14 01:27:20, michaelbai wrote: > > Justin, would ...
5 years, 10 months ago (2015-02-17 18:30:49 UTC) #8
qinmin
lgtm
5 years, 10 months ago (2015-02-17 18:38:18 UTC) #9
boliu
Thanks all :)
5 years, 10 months ago (2015-02-17 18:38:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928613004/1
5 years, 10 months ago (2015-02-17 18:39:34 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 19:01:44 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 19:02:32 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2cf2db603debf3125438284be17b3c160816fdf
Cr-Commit-Position: refs/heads/master@{#316618}

Powered by Google App Engine
This is Rietveld 408576698