Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: chrome/browser/ui/startup/bad_flags_prompt.cc

Issue 928593004: Show the 'unsupported flag' message for --{enable,disable}-blink-features. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/startup/bad_flags_prompt.h" 5 #include "chrome/browser/ui/startup/bad_flags_prompt.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/infobars/infobar_service.h" 10 #include "chrome/browser/infobars/infobar_service.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 translate::switches::kTranslateScriptURL, 67 translate::switches::kTranslateScriptURL,
68 68
69 // This flag gives extensions more powers. 69 // This flag gives extensions more powers.
70 extensions::switches::kExtensionsOnChromeURLs, 70 extensions::switches::kExtensionsOnChromeURLs,
71 71
72 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) 72 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
73 // Speech dispatcher is buggy, it can crash and it can make Chrome freeze. 73 // Speech dispatcher is buggy, it can crash and it can make Chrome freeze.
74 // http://crbug.com/327295 74 // http://crbug.com/327295
75 switches::kEnableSpeechDispatcher, 75 switches::kEnableSpeechDispatcher,
76 #endif 76 #endif
77
78 // These flags control Blink feature state, which is not supported and is
79 // intended only for use by Chromium developers.
80 switches::kDisableBlinkFeatures,
81 switches::kEnableBlinkFeatures,
82
77 NULL 83 NULL
78 }; 84 };
79 85
80 for (const char** flag = kBadFlags; *flag; ++flag) { 86 for (const char** flag = kBadFlags; *flag; ++flag) {
81 if (base::CommandLine::ForCurrentProcess()->HasSwitch(*flag)) { 87 if (base::CommandLine::ForCurrentProcess()->HasSwitch(*flag)) {
82 SimpleAlertInfoBarDelegate::Create( 88 SimpleAlertInfoBarDelegate::Create(
83 InfoBarService::FromWebContents(web_contents), 89 InfoBarService::FromWebContents(web_contents),
84 infobars::InfoBarDelegate::kNoIconID, 90 infobars::InfoBarDelegate::kNoIconID,
85 l10n_util::GetStringFUTF16(IDS_BAD_FLAGS_WARNING_MESSAGE, 91 l10n_util::GetStringFUTF16(IDS_BAD_FLAGS_WARNING_MESSAGE,
86 base::UTF8ToUTF16( 92 base::UTF8ToUTF16(
(...skipping 30 matching lines...) Expand all
117 user_data_dir.LossyDisplayName()); 123 user_data_dir.LossyDisplayName());
118 124
119 if (cleanup_resource_bundle) 125 if (cleanup_resource_bundle)
120 ResourceBundle::CleanupSharedInstance(); 126 ResourceBundle::CleanupSharedInstance();
121 127
122 // More complex dialogs cannot be shown before the earliest calls here. 128 // More complex dialogs cannot be shown before the earliest calls here.
123 ShowMessageBox(NULL, title, message, chrome::MESSAGE_BOX_TYPE_WARNING); 129 ShowMessageBox(NULL, title, message, chrome::MESSAGE_BOX_TYPE_WARNING);
124 } 130 }
125 131
126 } // namespace chrome 132 } // namespace chrome
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698