Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 928573003: [Telemetry] Make sure all page_test use 'action_name_to_run' except RasterizeAndMicro measurement. (Closed)

Created:
5 years, 10 months ago by nednguyen
Modified:
5 years, 10 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Make sure all page_test use 'action_name_to_run' except RasterizeAndMicro measurement. Replace the expensive operation options.CreateParser() with parser = optparse.OptionParser() BUG=418375 Committed: https://crrev.com/244e956b66e03b8b53f1e501fb4a3568e5317741 Cr-Commit-Position: refs/heads/master@{#316331}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tools/perf/measurements/measurement_smoke_test.py View 4 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
nednguyen
5 years, 10 months ago (2015-02-13 22:29:38 UTC) #3
sullivan
lgtm
5 years, 10 months ago (2015-02-13 22:33:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928573003/20001
5 years, 10 months ago (2015-02-13 22:45:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928573003/20001
5 years, 10 months ago (2015-02-13 22:56:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-13 23:54:37 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 23:55:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/244e956b66e03b8b53f1e501fb4a3568e5317741
Cr-Commit-Position: refs/heads/master@{#316331}

Powered by Google App Engine
This is Rietveld 408576698