Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(727)

Issue 928573002: Test top-level Document JS properties. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test top-level Document JS properties. Along the way, I rename some functions in pdfium_test.cc to match the style guide's FunctionName() syntax, adding "Example" to make them obviously different from the PDF internal code with similar name fragments. The purpose is to at least have some coverage for the setter/getter macros from JS_Define.h R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/58985096a7852263df68e87d9bfc335a3e2759bf

Patch Set 1 #

Patch Set 2 : Add missing expected result file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -5 lines) Patch
M samples/pdfium_test.cc View 4 chunks +10 lines, -5 lines 0 comments Download
A testing/resources/javascript/document_props.in View 1 chunk +143 lines, -0 lines 0 comments Download
A testing/resources/javascript/document_props_expected.txt View 1 1 chunk +97 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, please review.
5 years, 7 months ago (2015-02-13 19:58:22 UTC) #2
Lei Zhang
lgtm
5 years, 7 months ago (2015-02-13 20:04:09 UTC) #3
Tom Sepez
5 years, 7 months ago (2015-02-13 20:08:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
58985096a7852263df68e87d9bfc335a3e2759bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698