Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 928563003: Avoid twice clock reading (Closed)

Created:
5 years, 10 months ago by Xianzhu
Modified:
5 years, 10 months ago
Reviewers:
dsinclair, nduca
CC:
chromium-reviews, erikwright+watch_chromium.org, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid twice clock reading Add TRACE_EVENT_FLAG_EXPLICIT_TIMESTAMP which is set when an explicit timestamp is specified for the trace event. Only re-read clock if the flag is set. BUG=457441 Committed: https://crrev.com/02769c33ee568c5329ce85702428635e2ef442ee Cr-Commit-Position: refs/heads/master@{#317618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M base/trace_event/trace_event.h View 2 chunks +5 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Xianzhu
5 years, 10 months ago (2015-02-13 20:01:15 UTC) #2
nduca
lgtm
5 years, 10 months ago (2015-02-17 15:55:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928563003/1
5 years, 10 months ago (2015-02-23 17:43:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61739)
5 years, 10 months ago (2015-02-23 17:45:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928563003/1
5 years, 10 months ago (2015-02-23 17:51:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 19:14:02 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 19:14:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02769c33ee568c5329ce85702428635e2ef442ee
Cr-Commit-Position: refs/heads/master@{#317618}

Powered by Google App Engine
This is Rietveld 408576698