Remove the first-run search engine dialog/ballot.

Remove the first-run search engine dialog/ballot.
No changes to the Gtk and Mac first-run (reporting & default browser) dialog.

Tested optionally with GYP_DEFINES="branding=Chrome" and "--first-run --organic".
Chromium (all platforms): Shows the browser window directly (no dialog).
Chrome (Windows): Shows the browser window directly (no dialog).
Chrome (Linux and Mac): Shows the first-run (reporting & default browser) dialog before the browser window.

TODO(msw): Close crbug.com/111062 for removed test.
TODO(msw): Remove search engine icon/image resources (TemplateURL::logo_id_).

BUG=107005
TEST=No more standalone search engine selection dialog/ballot, Gtk and Mac first-run dialog works as before.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119189

[msw, 2012-01-24 23:07:18]

Hey Miranda, this is ready for review. PTAL; thanks!
I'll consider removing the icons in a followup.

[Miranda Callahan, 2012-01-24 23:29:48]

On 2012/01/24 23:07:18, msw wrote:
> Hey Miranda, this is ready for review. PTAL; thanks!
> I'll consider removing the icons in a followup.

LGTM! Removing the icons in a followup is fine; will need to be a separate CL
anyway because of their location.

[msw, 2012-01-24 23:37:50]

Ben can you give OWNERS approval? Thanks!

[msw, 2012-01-24 23:46:47]

+thakis for chrome/app/nibs/ & chrome/browser/ui/cocoa/ OWNERS.

[Nico, 2012-01-24 23:48:34]

owners lgtm

yay for deleting code!

[Ben Goodger (Google), 2012-01-26 00:56:07]

lgtm

[commit-bot: I haz the power, 2012-01-26 01:00:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/9285002/65

[commit-bot: I haz the power, 2012-01-26 01:00:41]

Can't apply patch for file chrome/browser/search_engines/template_url_service.h.
While running patch -p1 --forward --force;
patching file chrome/browser/search_engines/template_url_service.h
Hunk #1 FAILED at 1.
Hunk #3 succeeded at 544 (offset 5 lines).
1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/search_engines/template_url_service.h.rej

[commit-bot: I haz the power, 2012-01-26 01:09:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/9285002/14001

[commit-bot: I haz the power, 2012-01-26 01:09:54]

Presubmit check for 9285002-14001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/ui/gtk/first_run_dialog.h,chrome/browser/ui/gtk/first_run_dialog.cc

Presubmit checks took 1.8s to calculate.

[Elliot Glaysher, 2012-01-26 01:15:50]

lgtm

[commit-bot: I haz the power, 2012-01-26 01:21:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/9285002/14001

[commit-bot: I haz the power, 2012-01-26 04:05:32]

Change committed as 119189