Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 928413003: Rewrite fast/multicol/table-margin-collapse.html as a reftest. (Closed)

Created:
5 years, 10 months ago by mstensho (USE GERRIT)
Modified:
5 years, 10 months ago
Reviewers:
andersr
CC:
blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rewrite fast/multicol/table-margin-collapse.html as a reftest. R=andersr@opera.com BUG=386567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190413

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove useless purpleness. #

Messages

Total messages: 7 (2 generated)
mstensho (USE GERRIT)
5 years, 10 months ago (2015-02-17 16:51:26 UTC) #1
andersr
lgtm https://codereview.chromium.org/928413003/diff/1/LayoutTests/fast/multicol/table-margin-collapse.html File LayoutTests/fast/multicol/table-margin-collapse.html (right): https://codereview.chromium.org/928413003/diff/1/LayoutTests/fast/multicol/table-margin-collapse.html#newcode4 LayoutTests/fast/multicol/table-margin-collapse.html:4: .block { height:200px; background-color:purple; } Why is 'background-color: ...
5 years, 10 months ago (2015-02-18 10:29:04 UTC) #2
mstensho (USE GERRIT)
https://codereview.chromium.org/928413003/diff/1/LayoutTests/fast/multicol/table-margin-collapse.html File LayoutTests/fast/multicol/table-margin-collapse.html (right): https://codereview.chromium.org/928413003/diff/1/LayoutTests/fast/multicol/table-margin-collapse.html#newcode4 LayoutTests/fast/multicol/table-margin-collapse.html:4: .block { height:200px; background-color:purple; } On 2015/02/18 10:29:04, andersr ...
5 years, 10 months ago (2015-02-18 10:34:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928413003/20001
5 years, 10 months ago (2015-02-18 10:40:11 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 11:53:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190413

Powered by Google App Engine
This is Rietveld 408576698