Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 928363002: bindings: Fixes CSS property listing test to test attributes on prototype. (Closed)

Created:
5 years, 10 months ago by Yuki
Modified:
5 years, 10 months ago
Reviewers:
haraken, jsbell
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bindings: Fixes CSS property listing test to test attributes on prototype. Updates css-properties-as-js-properties test so it checks attributes on a prototype chain. BUG=43394 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190384

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 2 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yuki
Could you guys review this CL?
5 years, 10 months ago (2015-02-17 09:11:10 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-17 09:12:09 UTC) #3
jsbell
lgtm 2
5 years, 10 months ago (2015-02-17 18:21:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928363002/1
5 years, 10 months ago (2015-02-18 04:10:34 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 04:14:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190384

Powered by Google App Engine
This is Rietveld 408576698