Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 928353002: Files.app: Update toolbar layout and icons on it. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Update toolbar layout and icons on it. - Use pixel-perfect PNGs for icons on toolbar, instead of core-icons(SVG). - Update hover/focus color to be visible on white and blue background. - Change the shape of hover/focus background from square to circle. - Some minor layout change to comply with the latest spec. BUG=402344 TEST=manually compared with the mock. Committed: https://crrev.com/317f49316a9cf1971caca44c8e9cf85d4d64e7cc Cr-Commit-Position: refs/heads/master@{#316555}

Patch Set 1 #

Patch Set 2 : Removed unintentionally added file. #

Total comments: 4

Patch Set 3 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -36 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 2 5 chunks +107 lines, -6 lines 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/arrow_right.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/arrow_right_white.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/back.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/back_white.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/delete.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/delete_white.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/menu.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/menu_white.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/search.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/search_white.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/share.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/share_white.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/view_list.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/view_list_white.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/view_thumbnail.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/view_thumbnail_white.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/arrow_right.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/arrow_right_white.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/back.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/back_white.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/delete.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/delete_white.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/menu.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/menu_white.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/search.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/search_white.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/share.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/share_white.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/view_list.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/view_list_white.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/view_thumbnail.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/view_thumbnail_white.png View Binary file 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js View 1 chunk +2 lines, -15 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/location_line.js View 1 chunk +1 line, -2 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 2 5 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
fukino
Could you take a look? Thanks!
5 years, 10 months ago (2015-02-17 09:03:46 UTC) #2
yawano
https://codereview.chromium.org/928353002/diff/20001/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/928353002/diff/20001/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode516 ui/file_manager/file_manager/foreground/css/file_manager.css:516: display: none Order should be display < margin. https://codereview.chromium.org/928353002/diff/20001/ui/file_manager/file_manager/main.html ...
5 years, 10 months ago (2015-02-17 09:36:04 UTC) #3
fukino
Thanks! https://codereview.chromium.org/928353002/diff/20001/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/928353002/diff/20001/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode516 ui/file_manager/file_manager/foreground/css/file_manager.css:516: display: none On 2015/02/17 09:36:04, yawano wrote: > ...
5 years, 10 months ago (2015-02-17 09:57:25 UTC) #4
yawano
lgtm. Thank you!
5 years, 10 months ago (2015-02-17 09:58:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928353002/40001
5 years, 10 months ago (2015-02-17 10:00:41 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-17 10:33:01 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 10:33:46 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/317f49316a9cf1971caca44c8e9cf85d4d64e7cc
Cr-Commit-Position: refs/heads/master@{#316555}

Powered by Google App Engine
This is Rietveld 408576698