Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 928343003: CpuProfile: rename HSourcePosition to SourcePosition and move it to compiler.* (Closed)

Created:
5 years, 10 months ago by loislo
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne, alph, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CpuProfile: rename HSourcePosition to SourcePosition and move it to compiler.* Fix CompilationInfo::TraceInlinedFunction argument. Fix leaked CodeTracer in Isolate BUG=452067 LOG=n Committed: https://crrev.com/cc1458a9a41d63893fea1a42eb3a8bd88f90a707 Cr-Commit-Position: refs/heads/master@{#26689}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -180 lines) Patch
M src/compiler.h View 1 2 chunks +58 lines, -1 line 0 comments Download
M src/compiler.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M src/hydrogen.h View 10 chunks +27 lines, -42 lines 0 comments Download
M src/hydrogen.cc View 14 chunks +19 lines, -33 lines 0 comments Download
M src/hydrogen-instructions.h View 10 chunks +24 lines, -88 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +1 line, -14 lines 0 comments Download
M src/isolate.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
loislo
PTAL It is almost mechanical patch
5 years, 10 months ago (2015-02-17 09:58:52 UTC) #2
alph
lgtm
5 years, 10 months ago (2015-02-17 10:19:50 UTC) #3
Sven Panne
LGTM with a nit and a comment. https://codereview.chromium.org/928343003/diff/1/src/compiler.h File src/compiler.h (right): https://codereview.chromium.org/928343003/diff/1/src/compiler.h#newcode82 src/compiler.h:82: int value_; ...
5 years, 10 months ago (2015-02-17 11:08:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928343003/20001
5 years, 10 months ago (2015-02-17 12:03:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-17 12:26:10 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 12:26:26 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cc1458a9a41d63893fea1a42eb3a8bd88f90a707
Cr-Commit-Position: refs/heads/master@{#26689}

Powered by Google App Engine
This is Rietveld 408576698