Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 928323003: Do not use gold on aarch64 webview build. (Closed)

Created:
5 years, 10 months ago by Fabrice (no longer in Chrome)
Modified:
5 years, 10 months ago
Reviewers:
Nico, Torne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not use gold on aarch64 webview build. This causes build failures in the aosp build because the aarch64 gold linker is not present in the aosp tree. BUG=440793 Committed: https://crrev.com/63e5f56f87bfc864e65ee3c2518cce958b850a9e Cr-Commit-Position: refs/heads/master@{#316643}

Patch Set 1 #

Patch Set 2 : Add bug reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/common.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Fabrice (no longer in Chrome)
As discussed, PTAL.
5 years, 10 months ago (2015-02-17 10:43:23 UTC) #2
Torne
LGTM as long as nothing in chromium is going to actually depend on having gold ...
5 years, 10 months ago (2015-02-17 10:44:57 UTC) #3
Nico
This won't be necessary once the webview build no longer uses Android.mk, right? If so, ...
5 years, 10 months ago (2015-02-17 17:35:43 UTC) #4
Fabrice (no longer in Chrome)
On 2015/02/17 17:35:43, Nico wrote: > This won't be necessary once the webview build no ...
5 years, 10 months ago (2015-02-17 18:05:00 UTC) #6
Torne
On 2015/02/17 17:35:43, Nico wrote: > This won't be necessary once the webview build no ...
5 years, 10 months ago (2015-02-17 18:06:31 UTC) #7
Nico
lgtm Torne: Oh, that's a great point.
5 years, 10 months ago (2015-02-17 19:09:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928323003/20001
5 years, 10 months ago (2015-02-17 19:10:29 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-17 20:27:10 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 20:27:43 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63e5f56f87bfc864e65ee3c2518cce958b850a9e
Cr-Commit-Position: refs/heads/master@{#316643}

Powered by Google App Engine
This is Rietveld 408576698