Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 928243002: Fix v8rel script after adding roll branches. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 10 months ago
Reviewers:
tandrii(chromium)
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix v8rel script after adding roll branches. Use git hashes as keys when referring to releases, not pure commit position numbers as those are not unique. Better bailout to only check for recent releases. Add new branching method with a roll branch in heads to the v8rel test case. Fix the way v8 is referred to in DEPS files in the test cases. The test still had svn-number style. BUG=chromium:451975 TBR=tandrii@chromium.org NOTRY=true LOG=n TEST=./script_test.py Committed: https://crrev.com/b351e3020fadad986b965d8e3300d83088e64c38 Cr-Commit-Position: refs/heads/master@{#26669}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Review #

Patch Set 4 : Fix an error in the test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -66 lines) Patch
M tools/release/releases.py View 1 2 12 chunks +32 lines, -41 lines 0 comments Download
M tools/release/test_scripts.py View 1 2 3 7 chunks +69 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Achenbach
PTAL
5 years, 10 months ago (2015-02-16 14:58:49 UTC) #2
tandrii(chromium)
LGTM with 1 nit https://codereview.chromium.org/928243002/diff/20001/tools/release/releases.py File tools/release/releases.py (right): https://codereview.chromium.org/928243002/diff/20001/tools/release/releases.py#newcode433 tools/release/releases.py:433: nit: del extra space?
5 years, 10 months ago (2015-02-16 15:31:06 UTC) #3
Michael Achenbach
Done
5 years, 10 months ago (2015-02-16 16:40:38 UTC) #5
Michael Achenbach
Patch 4 fixes an error in the test. The chromium release retrieval should go backwards ...
5 years, 10 months ago (2015-02-16 16:51:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928243002/60001
5 years, 10 months ago (2015-02-16 16:52:48 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-16 17:00:51 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 17:01:07 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b351e3020fadad986b965d8e3300d83088e64c38
Cr-Commit-Position: refs/heads/master@{#26669}

Powered by Google App Engine
This is Rietveld 408576698