src/compiler/node-properties.h - Issue 928213003: Model exceptional edges from call nodes in TurboFan.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/node-properties.h

Issue 928213003: Model exceptional edges from call nodes in TurboFan. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebased. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/node-properties.h

diff --git a/src/compiler/node-properties.h b/src/compiler/node-properties.h

index b40faf39d407916c48501dc0d5d7dfe3ad92ed99..39a4d8ad3b1d17d66d9fef9c39fc31e1a38aa7bc 100644

--- a/src/compiler/node-properties.h

+++ b/src/compiler/node-properties.h

@@ -81,7 +81,8 @@ class NodeProperties FINAL {

static void RemoveNonValueInputs(Node* node);

// Replace value uses of {node} with {value} and effect uses of {node} with

- // {effect}. If {effect == NULL}, then use the effect input to {node}.

+ // {effect}. If {effect == NULL}, then use the effect input to {node}. All

+ // control uses will be relaxed assuming {node} cannot throw.

static void ReplaceWithValue(Node* node, Node* value, Node* effect = nullptr);