Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 928193002: Correctly propagate terminate exception in TryCall. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correctly propagate terminate exception in TryCall. BUG=v8:3892 LOG=Y Committed: https://crrev.com/a49b55b78844557b65a98e7a77dd26078157ed7f Cr-Commit-Position: refs/heads/master@{#26685}

Patch Set 1 #

Patch Set 2 : remove bogus assertion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
M src/execution.cc View 1 1 chunk +6 lines, -7 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
5 years, 10 months ago (2015-02-17 04:22:19 UTC) #2
Igor Sheludko
lgtm
5 years, 10 months ago (2015-02-17 11:19:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928193002/20001
5 years, 10 months ago (2015-02-17 11:24:49 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-17 11:44:34 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a49b55b78844557b65a98e7a77dd26078157ed7f Cr-Commit-Position: refs/heads/master@{#26685}
5 years, 10 months ago (2015-02-17 11:44:53 UTC) #7
Michael Achenbach
5 years, 10 months ago (2015-02-23 07:15:53 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/946973004/ by machenbach@chromium.org.

The reason for reverting is: See crbug.com/460412 and crbug.com/460356.
Reverting on master in order to roll from master again soon..

Powered by Google App Engine
This is Rietveld 408576698