Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 928073004: Fixing typos and errors in webaudio/offlinecontext-promise.html (Closed)

Created:
5 years, 10 months ago by hongchan
Modified:
5 years, 10 months ago
Reviewers:
Raymond Toy
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

The layout test webaudio/offlinecontext-promise.html has few minor issues: - missing semicolon. - typos. - wrong indentation and line break. - both test branches are passing. (there is no test failure.) BUG=460615 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190699

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M LayoutTests/webaudio/offlineaudiocontext-promise.html View 2 chunks +8 lines, -9 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
hongchan
PTAL.
5 years, 10 months ago (2015-02-23 21:29:33 UTC) #2
Raymond Toy
lgtm with one minor nit. https://codereview.chromium.org/928073004/diff/1/LayoutTests/webaudio/offlineaudiocontext-promise.html File LayoutTests/webaudio/offlineaudiocontext-promise.html (right): https://codereview.chromium.org/928073004/diff/1/LayoutTests/webaudio/offlineaudiocontext-promise.html#newcode6 LayoutTests/webaudio/offlineaudiocontext-promise.html:6: <script src="resources/audio-testing.js"></script> Does the ...
5 years, 10 months ago (2015-02-23 21:37:38 UTC) #3
hongchan
On 2015/02/23 at 21:37:38, rtoy wrote: > lgtm with one minor nit. > > https://codereview.chromium.org/928073004/diff/1/LayoutTests/webaudio/offlineaudiocontext-promise.html ...
5 years, 10 months ago (2015-02-23 21:41:10 UTC) #4
Raymond Toy
On 2015/02/23 21:41:10, hoch wrote: > On 2015/02/23 at 21:37:38, rtoy wrote: > > lgtm ...
5 years, 10 months ago (2015-02-23 21:53:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928073004/1
5 years, 10 months ago (2015-02-23 22:24:04 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 00:13:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190699

Powered by Google App Engine
This is Rietveld 408576698