Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: pkg/analyzer/lib/src/generated/engine.dart

Issue 928073003: Add more user tags to help trackdown analysis server perf bottlenecks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Reformat Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/index/store/split_store.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/engine.dart
diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart
index 44910a73df28c6b92f6af7fff3f1c2dc250ba140..7e6d0b154ddd9021e46a8bfea2c3157f64e77dee 100644
--- a/pkg/analyzer/lib/src/generated/engine.dart
+++ b/pkg/analyzer/lib/src/generated/engine.dart
@@ -2290,7 +2290,8 @@ class AnalysisContextImpl implements InternalAnalysisContext {
}
return PerformanceStatistics.performAnaysis.makeCurrentWhile(() {
int getStart = JavaSystem.currentTimeMillis();
- AnalysisTask task = nextAnalysisTask;
+ AnalysisTask task =
+ PerformanceStatistics.nextTask.makeCurrentWhile(() => nextAnalysisTask);
int getEnd = JavaSystem.currentTimeMillis();
if (task == null && _validateCacheConsistency()) {
task = nextAnalysisTask;
@@ -6820,7 +6821,8 @@ abstract class AnalysisTask {
"Task failed: $taskDescription",
new CaughtException(exception, stackTrace));
}
- return accept(visitor);
+ return PerformanceStatistics.analysisTaskVisitor.makeCurrentWhile(
+ () => accept(visitor));
}
@override
@@ -10519,6 +10521,19 @@ class PerformanceStatistics {
* The [PerformanceTag] for time spent in other phases of analysis.
*/
static PerformanceTag performAnaysis = new PerformanceTag('performAnaysis');
+
+ /**
+ * The [PerformanceTag] for time spent in the analysis task visitor after
+ * tasks are complete.
+ */
+ static PerformanceTag analysisTaskVisitor =
+ new PerformanceTag('analysisTaskVisitor');
+
+ /**
+ * The [PerformanceTag] for time spent in the getter
+ * AnalysisContextImpl.nextAnalysisTask.
+ */
+ static var nextTask = new PerformanceTag('nextAnalysisTask');
}
/**
« no previous file with comments | « pkg/analysis_server/lib/src/services/index/store/split_store.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698