Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 928063002: Changed the Launcher shelf icon in ChromeOS. (Closed)

Created:
5 years, 10 months ago by Matt Giuca
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed the Launcher shelf icon in ChromeOS. Was a 9-square app grid; now a magnifying glass. This better represents the new "Ares" launcher interface, which is focused on search. (The old icon is still used if the --disable-experimental-app-list flag is given.) BUG=458353 TBR=oshima@chromium.org Committed: https://crrev.com/4cadf30332cf12bdcdc5bfc70c9e9cd49d1ae8db Cr-Commit-Position: refs/heads/master@{#316712}

Patch Set 1 #

Patch Set 2 : Crush pngs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M ash/resources/ash_resources.grd View 1 chunk +2 lines, -1 line 0 comments Download
A ash/resources/default_100_percent/common/shelf/status_launcher_menu_icon.png View 1 Binary file 0 comments Download
A ash/resources/default_200_percent/common/shelf/status_launcher_menu_icon.png View 1 Binary file 0 comments Download
M ash/shelf/app_list_button.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Matt Giuca
calamity: For app_list owners. Screenshots on bug. oshima: For resource owners. PNGs have been crushed!
5 years, 10 months ago (2015-02-16 02:56:56 UTC) #2
calamity
app list lgtm.
5 years, 10 months ago (2015-02-16 03:28:33 UTC) #3
Matt Giuca
skuhne: ash/shelf owners (didn't notice we needed you before). sadrul: To fill in for oshima ...
5 years, 10 months ago (2015-02-17 23:11:33 UTC) #5
Matt Giuca
Oops, sadrul is not an OWNER in ash. +jamescook, for owners review of ash/resources. This ...
5 years, 10 months ago (2015-02-17 23:15:31 UTC) #7
James Cook
lgtm
5 years, 10 months ago (2015-02-17 23:40:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928063002/20001
5 years, 10 months ago (2015-02-17 23:42:43 UTC) #10
Mr4D (OOO till 08-26)
lgtm
5 years, 10 months ago (2015-02-18 00:20:38 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-18 00:41:23 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 00:42:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4cadf30332cf12bdcdc5bfc70c9e9cd49d1ae8db
Cr-Commit-Position: refs/heads/master@{#316712}

Powered by Google App Engine
This is Rietveld 408576698