Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 928003002: [gcc] Fix compiler warning turned into errors with gcc while compiling extension_sync_data_unittest… (Closed)

Created:
5 years, 10 months ago by vivekg_samsung
Modified:
5 years, 10 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[gcc] Fix compiler warning turned into errors with gcc while compiling extension_sync_data_unittest.cc With gcc toolchain, we get following error with EXPECT_FALSE error: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Werror=conversion-null] Changing EXPECT_EQ(...) to EXPECT_FALSE() fixes the error. R=kalman@chromium.org, rdevlin.cronin@chromium.org Committed: https://crrev.com/3b60d1cd04c369d93bfc2a5c137b51f515b3f07c Cr-Commit-Position: refs/heads/master@{#316587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/extensions/extension_sync_data_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
vivekg
PTAL, thank you.
5 years, 10 months ago (2015-02-15 15:16:54 UTC) #2
vivekg
Friendly ping.
5 years, 10 months ago (2015-02-17 02:34:14 UTC) #3
Devlin
lgtm. Sorry for the delay; Monday was a US holiday.
5 years, 10 months ago (2015-02-17 16:45:38 UTC) #4
vivekg
On 2015/02/17 16:45:38, Devlin wrote: > lgtm. > > Sorry for the delay; Monday was ...
5 years, 10 months ago (2015-02-17 16:51:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928003002/1
5 years, 10 months ago (2015-02-17 16:51:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 16:54:25 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 16:55:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b60d1cd04c369d93bfc2a5c137b51f515b3f07c
Cr-Commit-Position: refs/heads/master@{#316587}

Powered by Google App Engine
This is Rietveld 408576698