Issue 927953003: [strong] Forbid var.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -0 lines)			Patch
M	src/messages.js	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/parser.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/preparser.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	1	1 chunk	+54 lines, -0 lines	0 comments	Download
A	test/mjsunit/strong/var-let-const.js	View	1 2 3	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rossberg

LGTM, except that it would be good to also have js tests for all strong ...

5 years, 10 months ago (2015-02-17 13:35:50 UTC) #2

rossberg

Still LGTM https://codereview.chromium.org/927953003/diff/40001/test/mjsunit/strong/var-let-const.js File test/mjsunit/strong/var-let-const.js (right): https://codereview.chromium.org/927953003/diff/40001/test/mjsunit/strong/var-let-const.js#newcode20 test/mjsunit/strong/var-let-const.js:20: assertTrue(eval("'use strong'; const x = 0; x ...

5 years, 10 months ago (2015-02-17 14:57:28 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927953003/60001

5 years, 10 months ago (2015-02-17 15:14:19 UTC) #8

commit-bot: I haz the power

5 years, 10 months ago (2015-02-17 15:41:33 UTC) #10

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/34281c832269ef7e1538f141ab1d9bcaf41cac55
Cr-Commit-Position: refs/heads/master@{#26697}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 927953003: [strong] Forbid var. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : code review (rossberg@) #

Patch Set 4 : loop w const omg #

Messages