src/effects/SkXfermodeImageFilter.cpp - Issue 92793002: Fixed bad bitmap size crashes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkXfermodeImageFilter.cpp

Issue 92793002: Fixed bad bitmap size crashes (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Changed getSize name to getAllocatedSizeInBytes Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkXfermodeImageFilter.cpp

diff --git a/src/effects/SkXfermodeImageFilter.cpp b/src/effects/SkXfermodeImageFilter.cpp

index 620bde9fdb9d90e2a4f041e6421c748f028bbb85..3ab52950be3f40227ba975b800bbdb3cdedb27e0 100644

--- a/src/effects/SkXfermodeImageFilter.cpp

+++ b/src/effects/SkXfermodeImageFilter.cpp

@@ -72,6 +72,9 @@ bool SkXfermodeImageFilter::onFilterImage(Proxy* proxy,

foregroundOffset.fY -= bounds.top();

SkAutoTUnref<SkBaseDevice> device(proxy->createDevice(bounds.width(), bounds.height()));

+ if (NULL == device.get()) {

+ return false;

+ }

SkCanvas canvas(device);

SkPaint paint;

paint.setXfermodeMode(SkXfermode::kSrc_Mode);