src/effects/SkBlurImageFilter.cpp - Issue 92793002: Fixed bad bitmap size crashes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkBlurImageFilter.cpp

Issue 92793002: Fixed bad bitmap size crashes (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Changed getSize name to getAllocatedSizeInBytes Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkBlurImageFilter.cpp

diff --git a/src/effects/SkBlurImageFilter.cpp b/src/effects/SkBlurImageFilter.cpp

index 9bceda7db80ec3bd8af0a47b2f171ae8f0afa9f6..2795f3a872a198e2d7a7dfc55f0b5256474e380f 100644

--- a/src/effects/SkBlurImageFilter.cpp

+++ b/src/effects/SkBlurImageFilter.cpp

@@ -159,6 +159,10 @@ bool SkBlurImageFilter::onFilterImage(Proxy* proxy,

dst->setConfig(src.config(), srcBounds.width(), srcBounds.height());

dst->getBounds(&dstBounds);

dst->allocPixels();

+ if (!dst->getPixels()) {

+ return false;

+ }

int kernelSizeX, kernelSizeX3, lowOffsetX, highOffsetX;

int kernelSizeY, kernelSizeY3, lowOffsetY, highOffsetY;

getBox3Params(fSigma.width(), &kernelSizeX, &kernelSizeX3, &lowOffsetX, &highOffsetX);