Fixed bad bitmap size crashes

include/core/SkPixelRef.h

 
 /*
  * Copyright 2008 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkPixelRef_DEFINED
@@ skipping 239 matching lines @@
      *  For pixelrefs that don't have access to their raw pixels, they may be
      *  able to make a copy of them (e.g. if the pixels are on the GPU).
      *
      *  The base class implementation returns false;
      */
     virtual bool onReadPixels(SkBitmap* dst, const SkIRect* subsetOrNull);
 
     // default impl returns NULL.
     virtual SkData* onRefEncodedData();
 
+    // default impl returns 0.

[reed1, 2013/12/03 19:02:50]

Lets change the dox to document what this does/returns.
Is it the safe-size or the "normal" size? Is it useful/well-defined w/o
rowbytes?

[sugoi, 2013/12/03 19:07:22]

I'll add the dox. It should return the allocated size in memory of the current
SkPixelRef's internal data, such that offset + safe-size should never overflow
that amount of allocated memory (If I understand things correctly).

[sugoi, 2013/12/03 19:18:06]

Done.

+    virtual size_t getSize() const;
+
     /** Return the mutex associated with this pixelref. This value is assigned
         in the constructor, and cannot change during the lifetime of the object.
     */
     SkBaseMutex* mutex() const { return fMutex; }
 
     // serialization
     SkPixelRef(SkFlattenableReadBuffer&, SkBaseMutex*);
     virtual void flatten(SkFlattenableWriteBuffer&) const SK_OVERRIDE;
 
     // only call from constructor. Flags this to always be locked, removing
@@ skipping 26 matching lines @@
 
     // When copying a bitmap to another with the same shape and config, we can safely
     // clone the pixelref generation ID too, which makes them equivalent under caching.
     friend class SkBitmap;  // only for cloneGenID
     void cloneGenID(const SkPixelRef&);
 
     typedef SkFlattenable INHERITED;
 };
 
 #endif