Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 927883002: Implement chrome.platformKeys.getKeyPair(). (Closed)

Created:
5 years, 10 months ago by pneubeck (no reviews)
Modified:
5 years, 10 months ago
Reviewers:
arv
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement chrome.platformKeys.getKeyPair(). This also makes the chrome.platformKeys.subtleCrypto().sign() working. Still missing: per extension key permissions and UI changes. Reland of https://codereview.chromium.org/884073002/ BUG=450167 TBR=arv@chromium.org (for renderer_resources.grd change) Committed: https://crrev.com/bae26c1d31de27e89f358bca44e738925bb431ef Cr-Commit-Position: refs/heads/master@{#316410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+796 lines, -298 lines) Patch
M chrome/browser/chromeos/platform_keys/platform_keys.h View 6 chunks +39 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/platform_keys/platform_keys_nss.cc View 16 chunks +175 lines, -65 lines 0 comments Download
M chrome/browser/chromeos/platform_keys/platform_keys_service.h View 3 chunks +34 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/platform_keys/platform_keys_service.cc View 4 chunks +52 lines, -29 lines 0 comments Download
M chrome/browser/extensions/api/platform_keys/platform_keys_api.h View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/platform_keys/platform_keys_api.cc View 5 chunks +125 lines, -20 lines 0 comments Download
M chrome/common/extensions/api/platform_keys_internal.idl View 3 chunks +17 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/platform_keys_natives.cc View 3 chunks +20 lines, -3 lines 0 comments Download
A chrome/renderer/resources/extensions/platform_keys/get_public_key.js View 1 chunk +54 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/platform_keys/internal_api.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/platform_keys_custom_bindings.js View 1 chunk +35 lines, -1 line 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/platform_keys/basic.js View 3 chunks +229 lines, -141 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pneubeck (no reviews)
arv@chromium.org: Please review changes in chrome/renderer/resources/renderer_resources.grd
5 years, 10 months ago (2015-02-14 16:26:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927883002/1
5 years, 10 months ago (2015-02-15 09:02:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-15 09:05:57 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-15 09:06:46 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bae26c1d31de27e89f358bca44e738925bb431ef
Cr-Commit-Position: refs/heads/master@{#316410}

Powered by Google App Engine
This is Rietveld 408576698