Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 927843002: Adding binary files for platform_keys tests. (Closed)

Created:
5 years, 10 months ago by pneubeck (no reviews)
Modified:
5 years, 10 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding binary files for platform_keys tests. Was reviewed here: https://codereview.chromium.org/884073002/ Manually landing the binary files separately as 'git cl upload' chokes on them. BUG=450167 TBR=kaliamoorthi@chromium.org NOTRY=true Committed: https://crrev.com/1e61ba10e22ce271d1b7ae23754a1856d3c0f9a4 Cr-Commit-Position: refs/heads/master@{#316389}

Patch Set 1 #

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927843002/1
5 years, 10 months ago (2015-02-14 14:14:06 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/42694)
5 years, 10 months ago (2015-02-14 14:27:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927843002/1
5 years, 10 months ago (2015-02-14 16:19:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-14 16:20:15 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1e61ba10e22ce271d1b7ae23754a1856d3c0f9a4 Cr-Commit-Position: refs/heads/master@{#316389}
5 years, 10 months ago (2015-02-14 16:21:09 UTC) #10
pneubeck (no reviews)
5 years, 10 months ago (2015-02-14 20:23:57 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/925083002/ by pneubeck@chromium.org.

The reason for reverting is: Binary upload with CQ is not working. Will re-land
with 'git cl land'.

Powered by Google App Engine
This is Rietveld 408576698