Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: Source/core/html/track/TextTrackList.cpp

Issue 92783002: Move code that applies to audio and video tracks into TrackBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@tmp
Patch Set: Fix copyright, explicit constructor, and AtomicString oldKind, and replace mediaElement() with trac… Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/TextTrackList.cpp
diff --git a/Source/core/html/track/TextTrackList.cpp b/Source/core/html/track/TextTrackList.cpp
index 0d00ba33fee5220d99c603292f4bc7a5808b24e2..f3a7c3be63352dab6b635f21088413d2b32c0221 100644
--- a/Source/core/html/track/TextTrackList.cpp
+++ b/Source/core/html/track/TextTrackList.cpp
@@ -192,8 +192,8 @@ void TextTrackList::append(PassRefPtr<TextTrack> prpTrack)
invalidateTrackIndexesAfterTrack(track.get());
- ASSERT(!track->mediaElement() || track->mediaElement() == m_owner);
- track->setMediaElement(m_owner);
+ ASSERT(!track->trackList() || track->trackList() == this);
acolwell GONE FROM CHROMIUM 2013/12/06 01:35:54 "track->trackList() == this" seems a little weird.
+ track->setTrackList(this);
scheduleAddTrackEvent(track.release());
}
@@ -220,8 +220,8 @@ void TextTrackList::remove(TextTrack* track)
invalidateTrackIndexesAfterTrack(track);
- ASSERT(track->mediaElement() == m_owner);
- track->setMediaElement(0);
+ ASSERT(track->trackList() == this);
+ track->setTrackList(0);
tracks->remove(index);

Powered by Google App Engine
This is Rietveld 408576698