Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: cc/layers/scrollbar_layer_unittest.cc

Issue 927783002: cc: Stop passing the occlusion explicitly to AppendQuads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/layers/picture_layer_impl_unittest.cc ('k') | cc/layers/solid_color_layer_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/containers/hash_tables.h" 5 #include "base/containers/hash_tables.h"
6 #include "cc/animation/scrollbar_animation_controller.h" 6 #include "cc/animation/scrollbar_animation_controller.h"
7 #include "cc/layers/append_quads_data.h" 7 #include "cc/layers/append_quads_data.h"
8 #include "cc/layers/painted_scrollbar_layer.h" 8 #include "cc/layers/painted_scrollbar_layer.h"
9 #include "cc/layers/painted_scrollbar_layer_impl.h" 9 #include "cc/layers/painted_scrollbar_layer_impl.h"
10 #include "cc/layers/scrollbar_layer_interface.h" 10 #include "cc/layers/scrollbar_layer_interface.h"
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
395 layer_impl_tree_root->children()[1]); 395 layer_impl_tree_root->children()[1]);
396 scrollbar_layer_impl->SetBounds(gfx::Size(kTrackLength, kThumbThickness)); 396 scrollbar_layer_impl->SetBounds(gfx::Size(kTrackLength, kThumbThickness));
397 scrollbar_layer_impl->SetCurrentPos(10.f); 397 scrollbar_layer_impl->SetCurrentPos(10.f);
398 scrollbar_layer_impl->SetMaximum(100); 398 scrollbar_layer_impl->SetMaximum(100);
399 scrollbar_layer_impl->SetVisibleToTotalLengthRatio(0.4f); 399 scrollbar_layer_impl->SetVisibleToTotalLengthRatio(0.4f);
400 400
401 // Thickness should be overridden to 3. 401 // Thickness should be overridden to 3.
402 { 402 {
403 scoped_ptr<RenderPass> render_pass = RenderPass::Create(); 403 scoped_ptr<RenderPass> render_pass = RenderPass::Create();
404 AppendQuadsData data; 404 AppendQuadsData data;
405 scrollbar_layer_impl->AppendQuads(render_pass.get(), Occlusion(), &data); 405 scrollbar_layer_impl->AppendQuads(render_pass.get(), &data);
406 406
407 const QuadList& quads = render_pass->quad_list; 407 const QuadList& quads = render_pass->quad_list;
408 ASSERT_EQ(1u, quads.size()); 408 ASSERT_EQ(1u, quads.size());
409 EXPECT_EQ(DrawQuad::SOLID_COLOR, quads.front()->material); 409 EXPECT_EQ(DrawQuad::SOLID_COLOR, quads.front()->material);
410 EXPECT_EQ(gfx::Rect(6, 0, 39, 3), quads.front()->rect); 410 EXPECT_EQ(gfx::Rect(6, 0, 39, 3), quads.front()->rect);
411 } 411 }
412 412
413 // Contents scale should scale the draw quad. 413 // Contents scale should scale the draw quad.
414 scrollbar_layer_impl->draw_properties().contents_scale_x = 2.f; 414 scrollbar_layer_impl->draw_properties().contents_scale_x = 2.f;
415 scrollbar_layer_impl->draw_properties().contents_scale_y = 2.f; 415 scrollbar_layer_impl->draw_properties().contents_scale_y = 2.f;
416 { 416 {
417 scoped_ptr<RenderPass> render_pass = RenderPass::Create(); 417 scoped_ptr<RenderPass> render_pass = RenderPass::Create();
418 AppendQuadsData data; 418 AppendQuadsData data;
419 scrollbar_layer_impl->AppendQuads(render_pass.get(), Occlusion(), &data); 419 scrollbar_layer_impl->AppendQuads(render_pass.get(), &data);
420 420
421 const QuadList& quads = render_pass->quad_list; 421 const QuadList& quads = render_pass->quad_list;
422 ASSERT_EQ(1u, quads.size()); 422 ASSERT_EQ(1u, quads.size());
423 EXPECT_EQ(DrawQuad::SOLID_COLOR, quads.front()->material); 423 EXPECT_EQ(DrawQuad::SOLID_COLOR, quads.front()->material);
424 EXPECT_EQ(gfx::Rect(12, 0, 78, 6), quads.front()->rect); 424 EXPECT_EQ(gfx::Rect(12, 0, 78, 6), quads.front()->rect);
425 } 425 }
426 scrollbar_layer_impl->draw_properties().contents_scale_x = 1.f; 426 scrollbar_layer_impl->draw_properties().contents_scale_x = 1.f;
427 scrollbar_layer_impl->draw_properties().contents_scale_y = 1.f; 427 scrollbar_layer_impl->draw_properties().contents_scale_y = 1.f;
428 428
429 // For solid color scrollbars, position and size should reflect the 429 // For solid color scrollbars, position and size should reflect the
430 // current viewport state. 430 // current viewport state.
431 scrollbar_layer_impl->SetVisibleToTotalLengthRatio(0.2f); 431 scrollbar_layer_impl->SetVisibleToTotalLengthRatio(0.2f);
432 { 432 {
433 scoped_ptr<RenderPass> render_pass = RenderPass::Create(); 433 scoped_ptr<RenderPass> render_pass = RenderPass::Create();
434 AppendQuadsData data; 434 AppendQuadsData data;
435 scrollbar_layer_impl->AppendQuads(render_pass.get(), Occlusion(), &data); 435 scrollbar_layer_impl->AppendQuads(render_pass.get(), &data);
436 436
437 const QuadList& quads = render_pass->quad_list; 437 const QuadList& quads = render_pass->quad_list;
438 ASSERT_EQ(1u, quads.size()); 438 ASSERT_EQ(1u, quads.size());
439 EXPECT_EQ(DrawQuad::SOLID_COLOR, quads.front()->material); 439 EXPECT_EQ(DrawQuad::SOLID_COLOR, quads.front()->material);
440 EXPECT_EQ(gfx::Rect(8, 0, 19, 3), quads.front()->rect); 440 EXPECT_EQ(gfx::Rect(8, 0, 19, 3), quads.front()->rect);
441 } 441 }
442 442
443 // We shouldn't attempt div-by-zero when the maximum is zero. 443 // We shouldn't attempt div-by-zero when the maximum is zero.
444 scrollbar_layer_impl->SetCurrentPos(0.f); 444 scrollbar_layer_impl->SetCurrentPos(0.f);
445 scrollbar_layer_impl->SetMaximum(0); 445 scrollbar_layer_impl->SetMaximum(0);
446 { 446 {
447 scoped_ptr<RenderPass> render_pass = RenderPass::Create(); 447 scoped_ptr<RenderPass> render_pass = RenderPass::Create();
448 AppendQuadsData data; 448 AppendQuadsData data;
449 scrollbar_layer_impl->AppendQuads(render_pass.get(), Occlusion(), &data); 449 scrollbar_layer_impl->AppendQuads(render_pass.get(), &data);
450 450
451 const QuadList& quads = render_pass->quad_list; 451 const QuadList& quads = render_pass->quad_list;
452 ASSERT_EQ(1u, quads.size()); 452 ASSERT_EQ(1u, quads.size());
453 EXPECT_EQ(DrawQuad::SOLID_COLOR, quads.front()->material); 453 EXPECT_EQ(DrawQuad::SOLID_COLOR, quads.front()->material);
454 EXPECT_EQ(gfx::Rect(1, 0, 19, 3), quads.front()->rect); 454 EXPECT_EQ(gfx::Rect(1, 0, 19, 3), quads.front()->rect);
455 } 455 }
456 } 456 }
457 457
458 TEST_F(ScrollbarLayerTest, LayerDrivenSolidColorDrawQuads) { 458 TEST_F(ScrollbarLayerTest, LayerDrivenSolidColorDrawQuads) {
459 const int kThumbThickness = 3; 459 const int kThumbThickness = 3;
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
494 scroll_layer_impl->ScrollBy(gfx::Vector2dF(4.f, 0.f)); 494 scroll_layer_impl->ScrollBy(gfx::Vector2dF(4.f, 0.f));
495 495
496 scrollbar_layer_impl->SetBounds(gfx::Size(kTrackLength, kThumbThickness)); 496 scrollbar_layer_impl->SetBounds(gfx::Size(kTrackLength, kThumbThickness));
497 scrollbar_layer_impl->SetCurrentPos(4.f); 497 scrollbar_layer_impl->SetCurrentPos(4.f);
498 scrollbar_layer_impl->SetMaximum(8); 498 scrollbar_layer_impl->SetMaximum(8);
499 499
500 { 500 {
501 scoped_ptr<RenderPass> render_pass = RenderPass::Create(); 501 scoped_ptr<RenderPass> render_pass = RenderPass::Create();
502 502
503 AppendQuadsData data; 503 AppendQuadsData data;
504 scrollbar_layer_impl->AppendQuads(render_pass.get(), Occlusion(), &data); 504 scrollbar_layer_impl->AppendQuads(render_pass.get(), &data);
505 505
506 const QuadList& quads = render_pass->quad_list; 506 const QuadList& quads = render_pass->quad_list;
507 ASSERT_EQ(1u, quads.size()); 507 ASSERT_EQ(1u, quads.size());
508 EXPECT_EQ(DrawQuad::SOLID_COLOR, quads.front()->material); 508 EXPECT_EQ(DrawQuad::SOLID_COLOR, quads.front()->material);
509 EXPECT_EQ(gfx::Rect(3, 0, 3, 3), quads.front()->rect); 509 EXPECT_EQ(gfx::Rect(3, 0, 3, 3), quads.front()->rect);
510 } 510 }
511 } 511 }
512 512
513 class ScrollbarLayerSolidColorThumbTest : public testing::Test { 513 class ScrollbarLayerSolidColorThumbTest : public testing::Test {
514 public: 514 public:
(...skipping 540 matching lines...) Expand 10 before | Expand all | Expand 10 after
1055 TestScale(gfx::Rect(1240, 0, 15, 1333), 2.7754839f); 1055 TestScale(gfx::Rect(1240, 0, 15, 1333), 2.7754839f);
1056 TestScale(gfx::Rect(1240, 0, 15, 677), 2.46677136f); 1056 TestScale(gfx::Rect(1240, 0, 15, 677), 2.46677136f);
1057 1057
1058 // Horizontal Scrollbars. 1058 // Horizontal Scrollbars.
1059 TestScale(gfx::Rect(0, 1240, 1333, 15), 2.7754839f); 1059 TestScale(gfx::Rect(0, 1240, 1333, 15), 2.7754839f);
1060 TestScale(gfx::Rect(0, 1240, 677, 15), 2.46677136f); 1060 TestScale(gfx::Rect(0, 1240, 677, 15), 2.46677136f);
1061 } 1061 }
1062 1062
1063 } // namespace 1063 } // namespace
1064 } // namespace cc 1064 } // namespace cc
OLDNEW
« no previous file with comments | « cc/layers/picture_layer_impl_unittest.cc ('k') | cc/layers/solid_color_layer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698