Focus and trail cursor on Views Textfield selection clipboard paste.

Focus and trail cursor on Views Textfield selection clipboard paste.

Focus the textfield as needed (even with an empty clipboard).

Leave the cursor trailing the newly pasted text.
(don't restore and offset the prior cursor/selection)

Update and expand tests.

BUG=456581
TEST=Linux textfield/omnibox middle-click behaves as expected.
R=pkasting@chromium.org

Committed: https://crrev.com/973842b726e1effa9b5a89907e6eb4ca4f8cba2a
Cr-Commit-Position: refs/heads/master@{#316374}

[msw, 2015-02-13 23:35:55]

msw@chromium.org changed reviewers:
+ pkasting@chromium.org

[msw, 2015-02-13 23:38:43]

Hey Peter, please take a look; thanks!

https://codereview.chromium.org/927743002/diff/20001/ui/views/controls/textfi...
File ui/views/controls/textfield/textfield_unittest.cc (right):

https://codereview.chromium.org/927743002/diff/20001/ui/views/controls/textfi...
ui/views/controls/textfield/textfield_unittest.cc:1898: TEST_F(TextfieldTest,
DISABLED_SelectionClipboard) {
This passes locally on Linux, but I didn't solve the flakiness issue (reportedly
fails 6% of runs), so I'm leaving the test disabled, I guess.

https://codereview.chromium.org/927743002/diff/20001/ui/views/controls/textfi...
ui/views/controls/textfield/textfield_unittest.cc:1968: // TODO(msw): Add tests
with stored selections and select-all on focus.
I tested this manually, but didn't bother writing an Omnibox test for now.

[Peter Kasting, 2015-02-13 23:48:04]

LGTM

[msw, 2015-02-13 23:51:02]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2015-02-13 23:51:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/927743002/20001

[commit-bot: I haz the power, 2015-02-14 00:47:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-14 00:47:59]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2015-02-14 02:45:44]

New patchsets have been uploaded after l-g-t-m from pkasting@chromium.org

[msw, 2015-02-14 02:52:20]

Patchset #3 (id:40001) has been deleted

[msw, 2015-02-14 02:54:21]

I updated the behavior and tests slightly. Please take another look as you have
time, landing.

[msw, 2015-02-14 02:54:25]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2015-02-14 02:55:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/927743002/60001

[commit-bot: I haz the power, 2015-02-14 03:05:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-14 03:05:54]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2015-02-14 03:25:12]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2015-02-14 03:25:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/927743002/80001

[commit-bot: I haz the power, 2015-02-14 04:37:04]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-02-14 04:37:36]

Patchset 4 (id:??) landed as
https://crrev.com/973842b726e1effa9b5a89907e6eb4ca4f8cba2a
Cr-Commit-Position: refs/heads/master@{#316374}