Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 927733002: valgrind: Widen a suppression. (Closed)

Created:
5 years, 10 months ago by Nico
Modified:
5 years, 10 months ago
Reviewers:
Andre
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

valgrind: Widen a suppression. The Mac valgrind bot started reporting the following after https://codereview.chromium.org/918533005/ landed: UninitCondition Conditional jump or move depends on uninitialised value(s) x_zone_size find_registered_purgeable_zone malloc_make_nonpurgeable imageio_make_nonpurgeable cache_get_and_retain CGImageReadSessionGetCachedImageBlockData copyImageBlockSetPNG ImageProviderCopyImageBlockSetCallback img_blocks_create img_blocks_extent img_data_lock CGSImageDataLock ripc_AcquireImage ripc_DrawImage CGContextDrawImage __-[NSImageRep drawInRect:fromRect:operation:fraction:respectFlipped:hints:]_block_invoke_1 -[NSImageRep drawInRect:fromRect:operation:fraction:respectFlipped:hints:] __-[NSImage drawInRect:fromRect:operation:fraction:respectFlipped:hints:]_block_invoke_1 -[NSImage _usingBestRepresentationForRect:context:hints:body:] -[NSImage drawInRect:fromRect:operation:fraction:respectFlipped:hints:] -[NSImage hitTestRect:withImageDestinationRect:context:hints:flipped:] ui::ThreePartImage::HitTestImage(CGPoint, NSImage*, CGRect) const ui::ThreePartImage::HitTest(CGPoint, CGRect) const ui::test::ThreePartImageTest_HitTest_Test::TestBody() I can't see anything wrong, and a very similar stack is already suppressed, so just suppress the report. BUG=453996, 173779 TBR=andresantoso@chromium.org Committed: https://crrev.com/99ed184ac0f7faee6b9875cdbfe2d33b7a966ffd Cr-Commit-Position: refs/heads/master@{#316313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/valgrind/memcheck/suppressions_mac.txt View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
5 years, 10 months ago (2015-02-13 22:44:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927733002/1
5 years, 10 months ago (2015-02-13 22:46:36 UTC) #3
Andre
LGTM
5 years, 10 months ago (2015-02-13 23:02:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 23:06:53 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 23:07:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99ed184ac0f7faee6b9875cdbfe2d33b7a966ffd
Cr-Commit-Position: refs/heads/master@{#316313}

Powered by Google App Engine
This is Rietveld 408576698