Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 927703002: Clang update script: disable --with-android with LLVM_FORCE_HEAD_REVISION (Closed)

Created:
5 years, 10 months ago by hans
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clang update script: disable --with-android with LLVM_FORCE_HEAD_REVISION Unless we're targeting Android, Linux builders don't have the NDK checked out. BUG=452726 NOTRY=true Committed: https://crrev.com/d4f844473bd590970dc46c8c6ead8c3d9a7687d2 Cr-Commit-Position: refs/heads/master@{#316316}

Patch Set 1 #

Patch Set 2 : Actually, build it when targetting Android. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/clang/scripts/update.sh View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
hans
Please take a look. I first tried to configure the builder to set target_os=android when ...
5 years, 10 months ago (2015-02-13 22:41:28 UTC) #2
Nico
lgtm
5 years, 10 months ago (2015-02-13 22:45:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927703002/20001
5 years, 10 months ago (2015-02-13 22:48:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927703002/20001
5 years, 10 months ago (2015-02-13 23:06:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 23:08:34 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 23:09:18 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4f844473bd590970dc46c8c6ead8c3d9a7687d2
Cr-Commit-Position: refs/heads/master@{#316316}

Powered by Google App Engine
This is Rietveld 408576698