Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 927653005: Do not check for browser side navigation when loading a data url (Closed)

Created:
5 years, 10 months ago by clamy
Modified:
5 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Do not check for browser side navigation when loading a data url This CL makes it so that the request created by WebLocalFrame::loadData will not attempt to send the request to the browser when browser-side navigation is enabled. This is because this function is called when the navigation needs to be committed in the renderer. See https://codereview.chromium.org/906283003/ for the Chromium side CL for handling data urls. BUG=459033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
clamy
@japhet, creis: PTAL. This makes sure we can load data urls when PlzNavigate is enabled.
5 years, 10 months ago (2015-02-20 17:04:30 UTC) #2
Charlie Reis
LGTM
5 years, 10 months ago (2015-02-20 22:11:55 UTC) #3
clamy
@mkwst: PTAL
5 years, 10 months ago (2015-02-26 13:26:56 UTC) #5
Mike West
LGTM.
5 years, 10 months ago (2015-02-26 13:38:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927653005/1
5 years, 10 months ago (2015-02-26 13:39:21 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 14:47:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190919

Powered by Google App Engine
This is Rietveld 408576698