Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 92763002: Rename addTrack and removeTrack functions to addTextTrack and removeTextTrack. (Closed)

Created:
7 years ago by Brendan Long
Modified:
6 years, 9 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename addTrack and removeTrack functions to addTextTrack and removeTextTrack. This is refactoring in preparation for audio and video tracks. BUG=249427

Patch Set 1 #

Patch Set 2 : Rebased to apply cleanly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M Source/core/html/HTMLMediaElement.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 8 chunks +10 lines, -10 lines 0 comments Download
M Source/platform/graphics/media/MediaPlayer.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
acolwell GONE FROM CHROMIUM
lgtm
7 years ago (2013-12-03 21:44:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/92763002/1
7 years ago (2013-12-03 21:53:49 UTC) #2
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=12233
7 years ago (2013-12-03 22:11:24 UTC) #3
acolwell GONE FROM CHROMIUM
adamk: OWNERS lgtm please.
7 years ago (2013-12-03 22:27:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/92763002/1
6 years, 11 months ago (2014-01-13 17:52:33 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/html/HTMLMediaElement.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-13 17:52:37 UTC) #6
Brendan Long
eseidel: Can you review this for me so I can commit it?
6 years, 11 months ago (2014-01-14 23:03:32 UTC) #7
Brendan Long
6 years, 9 months ago (2014-03-04 20:17:29 UTC) #8
Message was sent while issue was closed.
This (or something similar to it) was committed manually by acolwell as revision
015930e22e4c95b35047682cd80ae0005f9acab6 (then reverted, then re-reverted).

Powered by Google App Engine
This is Rietveld 408576698