Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 927623002: Determine whether we can tweakAlphaForCoverage during Pipeline/XP creation. (Closed)

Created:
5 years, 10 months ago by egdaniel
Modified:
5 years, 10 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Determine whether we can tweakAlphaForCoverage during Pipeline/XP creation. BUG=skia: Committed: https://skia.googlesource.com/skia/+/f7c2d558726b8d629e1453b7201a0dd6bfda7b05

Patch Set 1 #

Patch Set 2 : Nit #

Total comments: 1

Patch Set 3 : review nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M include/gpu/GrInvariantOutput.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrProcOptInfo.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 2 chunks +21 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
egdaniel
5 years, 10 months ago (2015-02-13 18:18:37 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/927623002/diff/20001/include/gpu/GrXferProcessor.h File include/gpu/GrXferProcessor.h (right): https://codereview.chromium.org/927623002/diff/20001/include/gpu/GrXferProcessor.h#newcode77 include/gpu/GrXferProcessor.h:77: * Can tweak alpha for coverage. Currently this ...
5 years, 10 months ago (2015-02-13 18:32:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927623002/40001
5 years, 10 months ago (2015-02-13 19:58:05 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 20:11:04 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f7c2d558726b8d629e1453b7201a0dd6bfda7b05

Powered by Google App Engine
This is Rietveld 408576698