Issue 927613003: Revert of Disable console.log() dumping to LogMessages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 927613003: Revert of Disable console.log() dumping to LogMessages (Closed)

Created:
5 years, 10 months ago by David Trainor- moved to gerrit

Modified:
5 years, 10 months ago

Reviewers:
dzhioev (left Google), Charlie Reis

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Disable console.log() dumping to LogMessages (patchset #2 id:20001 of https://codereview.chromium.org/921513002/) Reason for revert: Breaking existing test infrastructure and workflows. Original issue's description: > Disable console.log() dumping to LogMessages > > Only dump console.log() to LogMessages if the page is a WebUI. Don't dump any > other console.log() messages regardles of whether or not the WebContents is > incognito or not. > > BUG=454569 > > Committed: https://crrev.com/e19cbf6a6f94dd3b4cfa667e675f99e09a5624da > Cr-Commit-Position: refs/heads/master@{#316002} TBR=creis@chromium.org,dzhioev@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=454569 Committed: https://crrev.com/b7d2a1d2236c61d43cc86fa9a89db9ecd2f62e3c Cr-Commit-Position: refs/heads/master@{#316255}

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	content/browser/frame_host/render_frame_host_impl.cc	View		1 chunk	+7 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

David Trainor- moved to gerrit

Created Revert of Disable console.log() dumping to LogMessages

5 years, 10 months ago (2015-02-13 19:08:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927613003/1

5 years, 10 months ago (2015-02-13 19:10:20 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-13 19:12:23 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b7d2a1d2236c61d43cc86fa9a89db9ecd2f62e3c
Cr-Commit-Position: refs/heads/master@{#316255}