Clean up perftesthelper.js style

Clean up perftesthelper.js style

This change makes tools/perf/page_sets/tough_animation_cases/resources/perftesthelper.js
consistent with the Chromium Javascript style guide:
 - Fixed indentation
 - Added missing semicolon
 - Renamed file to be underscore separated

Committed: https://crrev.com/30a1e4bc96550502e8607ac0f0a246eb42a61852
Cr-Commit-Position: refs/heads/master@{#316965}

[alancutter (OOO until 2018), 2015-02-17 20:57:01]

alancutter@chromium.org changed reviewers:
+ qyearsley@chromium.org

[alancutter (OOO until 2018), 2015-02-17 20:57:02]

Clean up requested in https://codereview.chromium.org/931723002/.

[qyearsley, 2015-02-17 21:19:09]

Hmm, the google style guide says to use file names without underscores,
withallthewordsmergedtogether.

https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showon...

(Kind of strange, and perf_test_helper.js seems OK to me, but anyway that's what
the style guide says.)

https://codereview.chromium.org/927583005/diff/1/tools/perf/page_sets/tough_a...
File tools/perf/page_sets/tough_animation_cases/resources/perf_test_helper.js
(right):

https://codereview.chromium.org/927583005/diff/1/tools/perf/page_sets/tough_a...
tools/perf/page_sets/tough_animation_cases/resources/perf_test_helper.js:4:
(function(){
Space between () and {.

https://codereview.chromium.org/927583005/diff/1/tools/perf/page_sets/tough_a...
tools/perf/page_sets/tough_animation_cases/resources/perf_test_helper.js:21:
temp = ((temp ^ 0xb55a4f09) ^ (temp >>> 16)) & 0xffffffff;
The style guide says "Long identifiers or values present problems for aligned
initialization lists, so always prefer non-aligned initialization."

That doesn't quite apply here, but if for some reason you felt that not aligning
the "& 0xffffffff" was better, then you could change that.

[alancutter (OOO until 2018), 2015-02-18 00:33:42]

On 2015/02/17 21:19:09, qyearsley wrote:
> Hmm, the google style guide says to use file names without underscores,
> withallthewordsmergedtogether.
> 
>
https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showon...
> 
> (Kind of strange, and perf_test_helper.js seems OK to me, but anyway that's
what
> the style guide says.)

The style guide also emphasises consistency with the existing code base, I think
in this instance it makes sense to use underscore naming.

https://codereview.chromium.org/927583005/diff/1/tools/perf/page_sets/tough_a...
File tools/perf/page_sets/tough_animation_cases/resources/perf_test_helper.js
(right):

https://codereview.chromium.org/927583005/diff/1/tools/perf/page_sets/tough_a...
tools/perf/page_sets/tough_animation_cases/resources/perf_test_helper.js:4:
(function(){
On 2015/02/17 21:19:08, qyearsley wrote:
> Space between () and {.

Done.

https://codereview.chromium.org/927583005/diff/1/tools/perf/page_sets/tough_a...
tools/perf/page_sets/tough_animation_cases/resources/perf_test_helper.js:21:
temp = ((temp ^ 0xb55a4f09) ^ (temp >>> 16)) & 0xffffffff;
On 2015/02/17 21:19:08, qyearsley wrote:
> The style guide says "Long identifiers or values present problems for aligned
> initialization lists, so always prefer non-aligned initialization."
> 
> That doesn't quite apply here, but if for some reason you felt that not
aligning
> the "& 0xffffffff" was better, then you could change that.

Non alignment would be my preference now that you point it out. This code should
probably avoid copy pasting magic numbers as well.

[qyearsley, 2015-02-18 17:42:08]

lgtm :-)

[alancutter (OOO until 2018), 2015-02-18 22:30:39]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2015-02-18 22:32:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/927583005/20001

[commit-bot: I haz the power, 2015-02-18 23:42:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-18 23:42:47]

Try jobs failed on following builders:
  android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes...)

[alancutter1, 2015-02-19 00:41:56]

The CQ bit was checked by alancutter@google.com

[commit-bot: I haz the power, 2015-02-19 00:43:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/927583005/20001

[commit-bot: I haz the power, 2015-02-19 01:49:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-19 01:50:56]

Patchset 2 (id:??) landed as
https://crrev.com/30a1e4bc96550502e8607ac0f0a246eb42a61852
Cr-Commit-Position: refs/heads/master@{#316965}

[epenner, 2015-02-19 19:08:05]

On 2015/02/19 01:50:56, I haz the power (commit-bot) wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/30a1e4bc96550502e8607ac0f0a246eb42a61852
> Cr-Commit-Position: refs/heads/master@{#316965}

This looks like a trivial refactor, however all Android tough_animation_cases
tests started failing and this is in the changelist. Mind if I speculatively
revert?

[epenner, 2015-02-19 19:10:56]

On 2015/02/19 19:08:05, epenner wrote:
> On 2015/02/19 01:50:56, I haz the power (commit-bot) wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/30a1e4bc96550502e8607ac0f0a246eb42a61852
> > Cr-Commit-Position: refs/heads/master@{#316965}
> 
> This looks like a trivial refactor, however all Android tough_animation_cases
> tests started failing and this is in the changelist. Mind if I speculatively
> revert?

Looks like this missed all files starting with "web_animations_". I'm going to
revert.

[epenner, 2015-02-19 19:11:45]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/941773002/ by epenner@chromium.org.

The reason for reverting is: Tough animation cases are failing due to a few
missed files in the refactor..