Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 927573002: Make sure key::kEnableWebBasedSignin policy also turns on command line arg (Closed)

Created:
5 years, 10 months ago by Roger Tawa OOO till Jul 10th
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure key::kEnableWebBasedSignin policy also turns on command line arg kEnableIframeBasedSignin. Regression in M41. BUG=457625 Committed: https://crrev.com/b964c203e990c51d0fc8f5c945312fd6e6455bc2 Cr-Commit-Position: refs/heads/master@{#316262}

Patch Set 1 : Add deprecation message #

Total comments: 4

Patch Set 2 : Address review comments #

Patch Set 3 : Add message that setting will be renamed #

Patch Set 4 : Make code more rebust #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chrome/browser/policy/chrome_browser_policy_connector.cc View 1 2 3 1 chunk +7 lines, -3 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 2 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
Roger Tawa OOO till Jul 10th
Hi Drew, Please let me know if there is something else to put in the ...
5 years, 10 months ago (2015-02-13 15:30:59 UTC) #2
Andrew T Wilson (Slow)
LGTM with the changes below. https://codereview.chromium.org/927573002/diff/20001/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/927573002/diff/20001/components/policy/resources/policy_templates.json#newcode1198 components/policy/resources/policy_templates.json:1198: 'supported_on': ['chrome.*:35-'], If the ...
5 years, 10 months ago (2015-02-13 15:38:47 UTC) #4
Roger Tawa OOO till Jul 10th
Thanks Drew. As discussed offline, all comments addressed, but I bumped the version numbers you ...
5 years, 10 months ago (2015-02-13 15:57:46 UTC) #7
Andrew T Wilson (Slow)
Still LGTM with new wording. Thanks!
5 years, 10 months ago (2015-02-13 16:10:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927573002/80001
5 years, 10 months ago (2015-02-13 16:12:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927573002/100001
5 years, 10 months ago (2015-02-13 18:37:37 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 10 months ago (2015-02-13 19:36:21 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 19:36:48 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b964c203e990c51d0fc8f5c945312fd6e6455bc2
Cr-Commit-Position: refs/heads/master@{#316262}

Powered by Google App Engine
This is Rietveld 408576698