Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 927533004: Labels when dumping fonts in Android parser test. (Closed)

Created:
5 years, 10 months ago by bungeman-skia
Modified:
5 years, 10 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Labels when dumping fonts in Android parser test. When the FontConfigParserAndroid test runs, it optionally dumps the configurations it creates for manual inspection. This is useful, but since three different configurations exist, it can be difficult to tell them apart. This simply prints a short header before each dump so that the dump can be identified. Committed: https://skia.googlesource.com/skia/+/3d47e2133cd089de9719d4626e51a7d259a887d7

Patch Set 1 #

Patch Set 2 : Remove extra line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M tests/FontConfigParser.cpp View 1 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bungeman-skia
I had this sitting in my stash, and it was helpful this time around, seemed ...
5 years, 10 months ago (2015-02-13 19:56:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927533004/20001
5 years, 10 months ago (2015-02-13 22:25:47 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-13 22:25:48 UTC) #5
tomhudson
lgtm
5 years, 10 months ago (2015-02-14 02:28:16 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 02:30:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3d47e2133cd089de9719d4626e51a7d259a887d7

Powered by Google App Engine
This is Rietveld 408576698