Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 927513003: Revert "Oilpan: Add more asserts to Heap::collectGarbage" (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
haraken, oilpan-reviews
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "Oilpan: Add more asserts to Heap::collectGarbage" This reverts commit c030706815f2d55e9f04ffdef39854059f7b5448. Reason for revert: broke heap unittests, http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%20%28dbg%29/builds/9631/steps/blink_heap_unittests/logs/HeapTest.LazySweepingLargeObjectPages R=haraken BUG=420515 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M Source/platform/heap/Heap.cpp View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
Please take a look.
5 years, 10 months ago (2015-02-13 14:21:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927513003/1
5 years, 10 months ago (2015-02-13 14:22:24 UTC) #3
haraken
Thanks, LGTM.
5 years, 10 months ago (2015-02-13 14:34:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927513003/1
5 years, 10 months ago (2015-02-13 15:13:48 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 15:15:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190148

Powered by Google App Engine
This is Rietveld 408576698