PNaCl: Impl the other atomicrmw operations: nand, max, min, umax, and umin.

test/Transforms/NaCl/atomic/extra-rmw-operations.ll

+; RUN: opt -nacl-rewrite-atomics -S < %s | FileCheck %s
+
+; Check rewriting nand, max, min, umax, umin atomicrmw operations.
+
+target datalayout = "p:32:32:32"
+
+; We test nand with all types, but for brevity's sake we don't do so for the
+; other operations.
+define i8 @test_nand_i8(i8* %ptr, i8 %value) {
+  %res = atomicrmw nand i8* %ptr, i8 %value seq_cst
+  ret i8 %res
+}
+; CHECK-LABEL: @test_nand_i8
+; CHECK-NEXT:    %1 = load i8, i8* %ptr, align 8

[JF, 2015/08/05 16:25:21]

This load needs to be atomic, or we need a fence before it.

The alignment is also wrong, since the input is just 1 byte.

[Richard Diamond, 2015/08/05 16:35:44]

Hm, indeed this is wrong. This patch isn't the culprit, though. I'll have to
submit a patch upstream fixing `llvm::expandAtomicRMWToCmpXchg`.

+; CHECK-NEXT:    br label %atomicrmw.start
+
+; CHECK:       atomicrmw.start:
+; CHECK-NEXT:    %loaded = phi i8 [ %1, %0 ], [ %3, %atomicrmw.start ]
+; CHECK-NEXT:    %2 = and i8 %loaded, %value
+; CHECK-NEXT:    %new = xor i8 %2, -1
+; CHECK-NEXT:    %3 = call i8 @llvm.nacl.atomic.cmpxchg.i8(i8* %ptr, i8 %loaded, i8 %new, i32 6, i32 6)
+; CHECK-NEXT:    %success = icmp eq i8 %3, %loaded
+; CHECK-NEXT:    br i1 %success, label %atomicrmw.end, label %atomicrmw.start
+
+; CHECK:       atomicrmw.end:
+; CHECK-NEXT:    ret i8 %3
+
+
+
+define i16 @test_nand_i16(i16* %ptr, i16 %value) {
+  %res = atomicrmw nand i16* %ptr, i16 %value seq_cst
+  ret i16 %res
+}
+; CHECK-LABEL: @test_nand_i16
+; CHECK: @llvm.nacl.atomic.cmpxchg
+
+define i32 @test_nand_i32(i32* %ptr, i32 %value) {
+  %res = atomicrmw nand i32* %ptr, i32 %value seq_cst
+  ret i32 %res
+}
+; CHECK-LABEL: @test_nand_i32
+; CHECK: @llvm.nacl.atomic.cmpxchg
+
+define i64 @test_nand_i64(i64* %ptr, i64 %value) {
+  %res = atomicrmw nand i64* %ptr, i64 %value seq_cst
+  ret i64 %res
+}
+; CHECK-LABEL: @test_nand_i64
+; CHECK: @llvm.nacl.atomic.cmpxchg
+
+
+define i32 @test_max(i32* %ptr, i32 %value) {
+  %res = atomicrmw max i32* %ptr, i32 %value seq_cst
+  ret i32 %res
+}
+; CHECK-LABEL: @test_max
+; CHECK: @llvm.nacl.atomic.cmpxchg
+
+define i32 @test_min(i32* %ptr, i32 %value) {
+  %res = atomicrmw min i32* %ptr, i32 %value seq_cst
+  ret i32 %res
+}
+; CHECK-LABEL: @test_min
+; CHECK: @llvm.nacl.atomic.cmpxchg
+
+define i32 @test_umax(i32* %ptr, i32 %value) {
+  %res = atomicrmw umax i32* %ptr, i32 %value seq_cst
+  ret i32 %res
+}
+; CHECK-LABEL: @test_umax
+; CHECK: @llvm.nacl.atomic.cmpxchg
+
+define i32 @test_umin(i32* %ptr, i32 %value) {
+  %res = atomicrmw umin i32* %ptr, i32 %value seq_cst
+  ret i32 %res
+}
+; CHECK-LABEL: @test_umin
+; CHECK: @llvm.nacl.atomic.cmpxchg