Fix the histograms whitelist for the OOP PDF plugin. (try 2)

Fix the histograms whitelist for the OOP PDF plugin. (try 2)

BUG=405305
Committed: https://crrev.com/53c256fe8661ea83c53f01700a552b04cbee77d2
Cr-Commit-Position: refs/heads/master@{#316928}

[Lei Zhang, 2015-02-13 09:24:20]

thestig@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2015-02-16 00:22:36]

Thanks Lei! It's unclear what exactly the problem was before though?

[raymes, 2015-02-18 02:26:01]

lgtm

[raymes, 2015-02-18 02:32:00]

(my guess is that some static initializer is implicitly created to do a
copy of the const char* const into a const char*)

On Wed Feb 18 2015 at 1:26:03 PM <raymes@chromium.org> wrote:

> lgtm
>
> https://codereview.chromium.org/927483002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[raymes, 2015-02-18 21:26:23]

Hey Lei,

I'd like to land this before Friday. I'm happy to CQ it but just want to make
sure you didn't have any concerns.

Thanks!
Raymes

[Lei Zhang, 2015-02-19 00:13:49]

On 2015/02/18 21:26:23, raymes wrote:
> Hey Lei,
> 
> I'd like to land this before Friday. I'm happy to CQ it but just want to make
> sure you didn't have any concerns.
> 
> Thanks!
> Raymes

Sure, landing this now.

I believe the explanation for the change is:
- with const char [], |ChromeContentClient::kPDFPluginPath| is just another name
for some block of data in the rodata section.
-- |kWhitelistedPluginBaseNames| can be calculated at compile time.
- with const char* const, |ChromeContentClient::kPDFPluginPath| is a pointer to
the block of data in the rodata section.
-- |kWhitelistedPluginBaseNames| can't be calculated at compile time, since
|ChromeContentClient::kPDFPluginPath| lives in a different translation unit.

[Lei Zhang, 2015-02-19 00:13:52]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-02-19 00:15:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/927483002/20001

[commit-bot: I haz the power, 2015-02-19 00:19:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-19 00:20:03]

Patchset 2 (id:??) landed as
https://crrev.com/53c256fe8661ea83c53f01700a552b04cbee77d2
Cr-Commit-Position: refs/heads/master@{#316928}