cc: Default threaded GPU rasterization to ON.

cc: Default threaded GPU rasterization to ON.

BUG=454500
Committed: https://crrev.com/96a23833e024783905297b60e7d86ca588ada45c
Cr-Commit-Position: refs/heads/master@{#316665}

[vmiura, 2015-02-16 19:33:35]

Patchset #2 (id:20001) has been deleted

[vmiura, 2015-02-17 05:27:14]

vmiura@chromium.org changed reviewers:
+ sievers@chromium.org

[vmiura, 2015-02-17 05:27:15]

sievers@chromium.org: PTAL.

others: FYI, I think this is ready to turn on.

[vangelis, 2015-02-17 07:14:06]

It would be useful to show some indication in the about:gpu page about what mode
is active. 

Should be relatively straightforward to make the change in:
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/gp...

We could for example repurpose the label for "threaded rasterization"
(originally used for impl-side-painting) to say Enabled when threaded ganesh is
on.

[vmiura, 2015-02-17 08:59:28]

On 2015/02/17 07:14:06, vangelis wrote:
> It would be useful to show some indication in the about:gpu page about what
mode
> is active. 
> 
> Should be relatively straightforward to make the change in:
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/gp...
> 
> We could for example repurpose the label for "threaded rasterization"
> (originally used for impl-side-painting) to say Enabled when threaded ganesh
is
> on.

Sure, I can add that.  It may be short lived though, and we can see the command
line args on the about:gpu page.  Still think we should do it?

[vangelis, 2015-02-17 17:12:29]

On 2015/02/17 08:59:28, vmiura wrote:
> On 2015/02/17 07:14:06, vangelis wrote:
> > It would be useful to show some indication in the about:gpu page about what
> mode
> > is active. 
> > 
> > Should be relatively straightforward to make the change in:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/gp...
> > 
> > We could for example repurpose the label for "threaded rasterization"
> > (originally used for impl-side-painting) to say Enabled when threaded ganesh
> is
> > on.
> 
> Sure, I can add that.  It may be short lived though, and we can see the
command
> line args on the about:gpu page.  Still think we should do it?

Right. The problem is that after this patch lands we won't be able to see an
"enable" flag in the command line so it will be hard to guess what the default
state is. On the other hand since this will likely be the only mode we support
for gpu rasterization, we can rely on chrome's version number to tell whether
we're running with or without the thread.

Let's keep it simple then for now. If for some reason the threaded rasterization
mode takes a while to stabilize we can think about adding the entry to
about:gpu.

[no sievers, 2015-02-17 21:19:34]

lgtm

[vmiura, 2015-02-17 21:56:05]

The CQ bit was checked by vmiura@chromium.org

[commit-bot: I haz the power, 2015-02-17 21:57:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/927463004/1

[commit-bot: I haz the power, 2015-02-17 22:00:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-17 22:01:17]

Patchset 1 (id:??) landed as
https://crrev.com/96a23833e024783905297b60e7d86ca588ada45c
Cr-Commit-Position: refs/heads/master@{#316665}

[Sami, 2015-02-18 16:31:40]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/936803002/ by skyostil@chromium.org.

The reason for reverting is: Breaks compositor rendering on Nexus 6:
crbug.com/459557.