Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 927463003: Upstream the third-party gcdwebserver dependency for iOS (Closed)

Created:
5 years, 10 months ago by stuartmorgan
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream the third-party gcdwebserver dependency for iOS This is used in iOS tests to serve test content without relying on network-layer interception. BUG=None Committed: https://crrev.com/94d1d75fa0eeb88e455e6bc38478cb78c8e6318c Cr-Commit-Position: refs/heads/master@{#319108}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -1 line) Patch
M .gitignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A ios/third_party/gcdwebserver/LICENSE View 1 chunk +24 lines, -0 lines 0 comments Download
A + ios/third_party/gcdwebserver/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
A ios/third_party/gcdwebserver/README.chromium View 1 chunk +10 lines, -0 lines 0 comments Download
A ios/third_party/gcdwebserver/gcdwebserver.gyp View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
stuartmorgan
5 years, 10 months ago (2015-02-15 11:35:01 UTC) #2
stuartmorgan
Ping
5 years, 9 months ago (2015-03-04 15:41:24 UTC) #3
rohitrao (ping after 24h)
LGTM https://codereview.chromium.org/927463003/diff/1/ios/third_party/gcdwebserver/gcdwebserver.gyp File ios/third_party/gcdwebserver/gcdwebserver.gyp (right): https://codereview.chromium.org/927463003/diff/1/ios/third_party/gcdwebserver/gcdwebserver.gyp#newcode1 ios/third_party/gcdwebserver/gcdwebserver.gyp:1: # Copyright 2014 The Chromium Authors. All rights ...
5 years, 9 months ago (2015-03-04 16:05:07 UTC) #4
stuartmorgan
https://codereview.chromium.org/927463003/diff/1/ios/third_party/gcdwebserver/gcdwebserver.gyp File ios/third_party/gcdwebserver/gcdwebserver.gyp (right): https://codereview.chromium.org/927463003/diff/1/ios/third_party/gcdwebserver/gcdwebserver.gyp#newcode1 ios/third_party/gcdwebserver/gcdwebserver.gyp:1: # Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 9 months ago (2015-03-04 16:06:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927463003/1
5 years, 9 months ago (2015-03-04 16:08:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/64419)
5 years, 9 months ago (2015-03-04 16:13:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927463003/20001
5 years, 9 months ago (2015-03-04 16:45:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/2039) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-04 16:54:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927463003/20001
5 years, 9 months ago (2015-03-04 17:10:45 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/2056) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-04 17:20:23 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927463003/20001
5 years, 9 months ago (2015-03-04 18:58:17 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 19:58:22 UTC) #21
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 19:58:50 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/94d1d75fa0eeb88e455e6bc38478cb78c8e6318c
Cr-Commit-Position: refs/heads/master@{#319108}

Powered by Google App Engine
This is Rietveld 408576698