win8/test/metro_registration_helper.cc - Issue 927443004: Remove uses of WaitForExitCodeWithTimeout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: win8/test/metro_registration_helper.cc

Issue 927443004: Remove uses of WaitForExitCodeWithTimeout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: win8/test/metro_registration_helper.cc

diff --git a/win8/test/metro_registration_helper.cc b/win8/test/metro_registration_helper.cc

index 160f602e2aba683408a6bd837078bbebe04f8e46..00f5b995d7f2a24418aa9ec653f6b30cab2c3886 100644

--- a/win8/test/metro_registration_helper.cc

+++ b/win8/test/metro_registration_helper.cc

@@ -58,9 +58,8 @@ bool RegisterTestDefaultBrowser() {

base::LaunchOptions());

if (register_process.IsValid()) {

int ret = 0;

- if (base::WaitForExitCodeWithTimeout(

- register_process.Handle(), &ret,

- base::TimeDelta::FromSeconds(kRegistrationTimeoutSeconds))) {

+ if (register_process.WaitForExitWithTimeout(

+ base::TimeDelta::FromSeconds(kRegistrationTimeoutSeconds), &ret)) {

if (ret == 0) {

return true;

} else {

« no previous file with comments | « win8/delegate_execute/chrome_util.cc ('k') | no next file » | no next file with comments »